Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_assign_groups_guess #3901

Merged
merged 7 commits into from
Feb 9, 2023
Merged

Improve test_assign_groups_guess #3901

merged 7 commits into from
Feb 9, 2023

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Feb 7, 2023

Related issue
#3863

Description

After the research done in #3876, we could see that this test should be improved by checking the expected logs.

Updated

  • Updated main.yml in master and worker provisioning: enable remoted debug.
  • Updated test_assign_groups_guess: search expected logs

Testing performed

Tester Test path Jenkins Local Commit Notes
@juliamagan (Developer) system/test_cluster/test_agent_groups/test_assign_groups_guess.py 🚫 🚫 🚫 🟢 🟢 🟢 d31ea7d Nothing to highlight
@user (Reviewer) 🚫 🚫 🚫 🚫 🚫 🚫 Nothing to highlight

@juliamagan juliamagan self-assigned this Feb 7, 2023
@juliamagan juliamagan linked an issue Feb 7, 2023 that may be closed by this pull request
Copy link
Contributor

@jmv74211 jmv74211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take into account that these tests only check 1 group cases. We have to check if the multigroups tests are also necessary to implement now.

@jmv74211 jmv74211 merged commit 2c9bc46 into 4.4 Feb 9, 2023
@jmv74211 jmv74211 deleted the 3863-guess-groups-improve branch February 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test_assign_groups_guess
2 participants